summaryrefslogtreecommitdiff
path: root/patches/monero/README.md
diff options
context:
space:
mode:
authorCzarek Nakamoto <cyjan@mrcyjanek.net>2024-04-12 11:13:43 +0200
committerCzarek Nakamoto <cyjan@mrcyjanek.net>2024-04-12 11:13:43 +0200
commit125e64f11f2201deaf2c291a586211a4410da57a (patch)
tree1f78db1ad19e14e284c128fe5a310edf2d1e1de1 /patches/monero/README.md
parentb003970d7f445489a588f4d0358af98d995969d2 (diff)
update patchesv0.18.3.3-RC23
update readme
Diffstat (limited to 'patches/monero/README.md')
-rw-r--r--patches/monero/README.md30
1 files changed, 19 insertions, 11 deletions
diff --git a/patches/monero/README.md b/patches/monero/README.md
index 4aa33d1..b840515 100644
--- a/patches/monero/README.md
+++ b/patches/monero/README.md
@@ -1,35 +1,43 @@
-> 0000 to 0003 were created most likely by feather dev, anonero monero repository got nuked and now says that I made the changes, so I am unable to credit the original authors, http://git.anonero5wmhraxqsvzq2ncgptq6gq45qoto6fnkfwughfl4gbt44swad.onion/ANONERO/monero/commits/branch/v0.18.3.3-anonero
+> 0001 to 0004 were created most likely by feather dev, anonero monero repository got nuked and now says that I made the changes, so I am unable to credit the original authors, http://git.anonero5wmhraxqsvzq2ncgptq6gq45qoto6fnkfwughfl4gbt44swad.onion/ANONERO/monero/commits/branch/v0.18.3.3-anonero
-# 0000-polyseed
+# 0001-polyseed
-Polyseed support for wallets [planned in long distant future as a part of walet3 - not getting upstream, no PR available]
+Polyseed support for wallets [planned in long distant future as a part of walet3 - not getting upstream, no PR available].
-# 0001-background-sync
+Note, only English support is available due to issues with normalization libraries.
-https://github.com/monero-project/monero/pull/8619
+> tobtoht: You may also want to reconsider supporting languages other than English: https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki#wordlists (this is about BIP39, but because unicode normalization is such a PITA it will become true for Polyseed wallets as well)
-# 0002-airgap
+Considering the fact that even Feather Wallet doesn't support non-english seeds, it makes sense to go that way.
+
+At least until (if ever) feather wallet supports multi-language polyseed seeds I don't think it is a good idea to support them, especially because of possible issues when targetting different platforms.
+
+# 0002-background-sync
+
+Sourced from: https://github.com/monero-project/monero/pull/8617, no changes except for merge conflicts.
+
+# 0003-airgap
Cool functions for offline transactions
-# 0003-coin-control
+# 0004-coin-control
Coin control patch, I was able to trace it's orgins back to wownero/monerujo.
-# 0004-fix-build
+# 0005-fix-build
Fix cross compilation for linux
-# 0005-macos-build-fix
+# 0006-macos-build-fix
Fixes cross compilation for MacOS targets
-# 0006-fix-make-debug-test-target
+# 0007-fix-make-debug-test-target
I had some debugging to do, I don't remember actually why I decided to run the tests, but since it is a fix I've decided to leave it in here just in case.
-# 0007-fix-missing-___clear_cache-when-targetting-iOS
+# 0008-fix-missing-___clear_cache-when-targetting-iOS
https://github.com/tevador/RandomX/pull/294 \ No newline at end of file