summaryrefslogtreecommitdiff
path: root/patches/monero/0014-use-proper-error-handling-in-get_seed.patch
diff options
context:
space:
mode:
authorcyan <cyjan@mrcyjanek.net>2024-08-26 06:57:16 +0200
committerGitHub <noreply@github.com>2024-08-26 06:57:16 +0200
commitd7a38301ece1a166af7b230e34be6e950e0aeb3c (patch)
treea4eae4e3c05424474dc23e6feab6528a1d0a1615 /patches/monero/0014-use-proper-error-handling-in-get_seed.patch
parent9c5459c51ed966f77e1bc22e787e858cd2c53c86 (diff)
Monero v0.18.3.4 (#38)
* updated monero dependency * update patches for v0.18.3.4 * update generate checksum to include version of submodule as well
Diffstat (limited to 'patches/monero/0014-use-proper-error-handling-in-get_seed.patch')
-rw-r--r--patches/monero/0014-use-proper-error-handling-in-get_seed.patch68
1 files changed, 0 insertions, 68 deletions
diff --git a/patches/monero/0014-use-proper-error-handling-in-get_seed.patch b/patches/monero/0014-use-proper-error-handling-in-get_seed.patch
deleted file mode 100644
index 892a827..0000000
--- a/patches/monero/0014-use-proper-error-handling-in-get_seed.patch
+++ /dev/null
@@ -1,68 +0,0 @@
-From 50e09195fcb79debf5951c69717b9d4f239ed8e1 Mon Sep 17 00:00:00 2001
-From: Czarek Nakamoto <cyjan@mrcyjanek.net>
-Date: Mon, 24 Jun 2024 10:49:12 +0200
-Subject: [PATCH] use proper error handling in get_seed
-
----
- src/wallet/api/wallet.cpp | 17 ++++++++++++-----
- src/wallet/wallet2.cpp | 3 +++
- 2 files changed, 15 insertions(+), 5 deletions(-)
-
-diff --git a/src/wallet/api/wallet.cpp b/src/wallet/api/wallet.cpp
-index ac3e6d51e..8bdd75a5a 100644
---- a/src/wallet/api/wallet.cpp
-+++ b/src/wallet/api/wallet.cpp
-@@ -880,12 +880,19 @@ bool WalletImpl::close(bool store)
-
- std::string WalletImpl::seed(const std::string& seed_offset) const
- {
-- if (checkBackgroundSync("cannot get seed"))
-+ if (checkBackgroundSync("cannot get seed")) {
-+ setStatusError("cannot get seed");
- return std::string();
-- epee::wipeable_string seed;
-- if (m_wallet)
-- m_wallet->get_seed(seed, seed_offset);
-- return std::string(seed.data(), seed.size()); // TODO
-+ }
-+ try {
-+ epee::wipeable_string seed;
-+ if (m_wallet)
-+ m_wallet->get_seed(seed, seed_offset);
-+ return std::string(seed.data(), seed.size()); // TODO
-+ } catch (const std::exception &e) {
-+ setStatusError(e.what());
-+ return std::string();
-+ }
- }
-
- bool WalletImpl::getPolyseed(std::string &seed_words, std::string &passphrase) const
-diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp
-index 23b56810e..f7bdf2429 100644
---- a/src/wallet/wallet2.cpp
-+++ b/src/wallet/wallet2.cpp
-@@ -1452,11 +1452,13 @@ bool wallet2::get_seed(epee::wipeable_string& electrum_words, const epee::wipeab
- bool keys_deterministic = is_deterministic();
- if (!keys_deterministic)
- {
-+ THROW_WALLET_EXCEPTION(error::wallet_internal_error, "This is not a deterministic wallet");
- std::cout << "This is not a deterministic wallet" << std::endl;
- return false;
- }
- if (seed_language.empty())
- {
-+ THROW_WALLET_EXCEPTION(error::wallet_internal_error, "seed_language not set");
- std::cout << "seed_language not set" << std::endl;
- return false;
- }
-@@ -1466,6 +1468,7 @@ bool wallet2::get_seed(epee::wipeable_string& electrum_words, const epee::wipeab
- key = cryptonote::encrypt_key(key, passphrase);
- if (!crypto::ElectrumWords::bytes_to_words(key, electrum_words, seed_language))
- {
-+ THROW_WALLET_EXCEPTION(error::wallet_internal_error, "Failed to create seed from key for language: "+seed_language+", falling back to English.");
- std::cout << "Failed to create seed from key for language: " << seed_language << ", falling back to English." << std::endl;
- crypto::ElectrumWords::bytes_to_words(key, electrum_words, "English");
- }
---
-2.39.2
-