summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCzarek Nakamoto <cyjan@mrcyjanek.net>2024-06-25 10:56:47 +0200
committerCzarek Nakamoto <cyjan@mrcyjanek.net>2024-06-25 10:56:47 +0200
commit4f4cde82f799b191576f619a7653fe5f6f366758 (patch)
tree3cb2c7ed826ff7a0e67ffc3c3aee656bbf17684c
parent57f19be240a40e15e6f58d4b3945ea75bdc61279 (diff)
add the patch to monero codebase
-rw-r--r--patches/monero/0014-use-proper-error-handling-in-get_seed.patch68
1 files changed, 68 insertions, 0 deletions
diff --git a/patches/monero/0014-use-proper-error-handling-in-get_seed.patch b/patches/monero/0014-use-proper-error-handling-in-get_seed.patch
new file mode 100644
index 0000000..892a827
--- /dev/null
+++ b/patches/monero/0014-use-proper-error-handling-in-get_seed.patch
@@ -0,0 +1,68 @@
+From 50e09195fcb79debf5951c69717b9d4f239ed8e1 Mon Sep 17 00:00:00 2001
+From: Czarek Nakamoto <cyjan@mrcyjanek.net>
+Date: Mon, 24 Jun 2024 10:49:12 +0200
+Subject: [PATCH] use proper error handling in get_seed
+
+---
+ src/wallet/api/wallet.cpp | 17 ++++++++++++-----
+ src/wallet/wallet2.cpp | 3 +++
+ 2 files changed, 15 insertions(+), 5 deletions(-)
+
+diff --git a/src/wallet/api/wallet.cpp b/src/wallet/api/wallet.cpp
+index ac3e6d51e..8bdd75a5a 100644
+--- a/src/wallet/api/wallet.cpp
++++ b/src/wallet/api/wallet.cpp
+@@ -880,12 +880,19 @@ bool WalletImpl::close(bool store)
+
+ std::string WalletImpl::seed(const std::string& seed_offset) const
+ {
+- if (checkBackgroundSync("cannot get seed"))
++ if (checkBackgroundSync("cannot get seed")) {
++ setStatusError("cannot get seed");
+ return std::string();
+- epee::wipeable_string seed;
+- if (m_wallet)
+- m_wallet->get_seed(seed, seed_offset);
+- return std::string(seed.data(), seed.size()); // TODO
++ }
++ try {
++ epee::wipeable_string seed;
++ if (m_wallet)
++ m_wallet->get_seed(seed, seed_offset);
++ return std::string(seed.data(), seed.size()); // TODO
++ } catch (const std::exception &e) {
++ setStatusError(e.what());
++ return std::string();
++ }
+ }
+
+ bool WalletImpl::getPolyseed(std::string &seed_words, std::string &passphrase) const
+diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp
+index 23b56810e..f7bdf2429 100644
+--- a/src/wallet/wallet2.cpp
++++ b/src/wallet/wallet2.cpp
+@@ -1452,11 +1452,13 @@ bool wallet2::get_seed(epee::wipeable_string& electrum_words, const epee::wipeab
+ bool keys_deterministic = is_deterministic();
+ if (!keys_deterministic)
+ {
++ THROW_WALLET_EXCEPTION(error::wallet_internal_error, "This is not a deterministic wallet");
+ std::cout << "This is not a deterministic wallet" << std::endl;
+ return false;
+ }
+ if (seed_language.empty())
+ {
++ THROW_WALLET_EXCEPTION(error::wallet_internal_error, "seed_language not set");
+ std::cout << "seed_language not set" << std::endl;
+ return false;
+ }
+@@ -1466,6 +1468,7 @@ bool wallet2::get_seed(epee::wipeable_string& electrum_words, const epee::wipeab
+ key = cryptonote::encrypt_key(key, passphrase);
+ if (!crypto::ElectrumWords::bytes_to_words(key, electrum_words, seed_language))
+ {
++ THROW_WALLET_EXCEPTION(error::wallet_internal_error, "Failed to create seed from key for language: "+seed_language+", falling back to English.");
+ std::cout << "Failed to create seed from key for language: " << seed_language << ", falling back to English." << std::endl;
+ crypto::ElectrumWords::bytes_to_words(key, electrum_words, "English");
+ }
+--
+2.39.2
+