monero_c.git, branch v0.18.3.3-RC29

unsigned long long

2024-04-19T14:44:01+00:00

iOS build: do not fail due to mv: Directory not empty

2024-04-19T14:39:09+00:00

fix regarding the issues raised during security audit

2024-04-19T14:37:42+00:00

In the polyseed-examples repository, the `utf8_nfc` and `utf8_nfkd` functions will never return a value exceeding `POLYSEED_STR_SIZE - 1` In your code, the utf8_norm function has variable return behavior that seems odd In case of a normalization error, the underlying normalizer will return a negative value, at which point your function just returns POLYSEED_STR_SIZE (this is unclear) In case the buffer isn't large enough, the normalizer will return the required buffer size but have undefined internal behavior, at which point your function returns a value exceeding POLYSEED_STR_SIZE Otherwise, it uses the normalizer's return value (indicating the written size) to continue with re-encoding tobtoht: Czarek Nakamoto: polyseed asserts that the return value < POLYSEED_STR_SIZE, so if normalization fails the program crashes.. > I think my idea was to have have polyseed check the return value and return an error code instead of asserting, which would in turn throw the "Unicode normalization failed" error > I'll upstream that. In the meantime you can replace the injected function with ```cpp inline size_t utf8_norm(const char* str, polyseed_str norm, utf8proc_option_t options) { utf8proc_int32_t buffer[POLYSEED_STR_SIZE]; utf8proc_ssize_t result; result = utf8proc_decompose(reinterpret_cast(str), 0, buffer, POLYSEED_STR_SIZE, options); if (result < 0 || result > (POLYSEED_STR_SIZE - 1)) { throw std::runtime_error("Unicode normalization failed"); } result = utf8proc_reencode(buffer, result, options); if (result < 0 || result > POLYSEED_STR_SIZE) { throw std::runtime_error("Unicode normalization failed"); } strcpy(norm, reinterpret_cast(buffer)); sodium_memzero(buffer, sizeof(buffer)); return result; } ```

Wallet::reconnectDevice implementation

2024-04-19T14:28:59+00:00

legacy code removal + deprecation notice

2024-04-19T14:28:07+00:00

can't remove the runTHread code just yet as xmruw depends on it, and I don't have enough hours in the day to fix that at the moment.

make vectorToString behave as it should, without appending separators when it isn't required

2024-04-19T14:25:05+00:00

add multi dest tx support

2024-04-17T14:16:22+00:00

WIP: cake stuff

2024-04-15T20:18:55+00:00

polyseed fix

2024-04-15T14:17:54+00:00

tobtoht: Since only the composed languages are broken, it could also be that canonical composition is producing weird output. Try dumping whatever seed string is being fed to polyseed_decode to hex and we should be able to tell. Or try removing UTF8PROC_LUMP from utf8_nfc

Merge pull request #2 from cypherstack/scripts

2024-04-12T17:23:41+00:00

fix openssl script re: previous commit